Skip to content

i18n: Change style of sentence #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Valdnet merged 4 commits into from
Aug 25, 2022
Merged

i18n: Change style of sentence #2334

Valdnet merged 4 commits into from
Aug 25, 2022

Conversation

@Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Aug 25, 2022

  1. Changing the style of the sentence.
  2. Unifying the sentence with Talk Nextcloud l10n: Change style of sentence spreed#7790.

Signed-off-by: Valdnet [email protected]

@Valdnet
i18n: Change style of sentence
7cdd518 
1. Changing the style of the sentence.
2. Unifying the sentence with Talk Nextcloud.

Signed-off-by: Valdnet <[email protected]>
@Valdnet Valdnet requested review from mahibi and rakekniven August 25, 2022 06:59
@Valdnet Valdnet self-assigned this Aug 25, 2022
@Valdnet
i10n: Change word
675773f 
Signed-off-by: Valdnet <[email protected]>
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 25, 2022

/backport to stable-14.1

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 25, 2022

/backport to stable-14.2

rakekniven
rakekniven requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@rakekniven rakekniven left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a certain time" sounds better than "a while" IMHO.
Is this the same wording as it is used for server string?

EDIT:
Yes, see nextcloud/spreed#7790

@Valdnet
i18n: Correct word
2bba950 
Signed-off-by: Valdnet <[email protected]>
@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 25, 2022

@rakekniven Thanks, my oversight 😉.

@Valdnet Valdnet requested a review from rakekniven August 25, 2022 10:25
@Valdnet
i18n: Changing verb
c01b02f 
Signed-off-by: Valdnet <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2334-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@Valdnet Valdnet merged commit bc2e19a into master Aug 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the Valdnet-patch-1 branch August 25, 2022 18:11
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Aug 25, 2022

The backport to stable-14.1 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Aug 25, 2022

The backport to stable-14.2 failed. Please do this backport manually.

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 25, 2022

/backport to stable-14.2

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 25, 2022

/backport to stable-14.1

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Aug 25, 2022

The backport to stable-14.2 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Aug 25, 2022

The backport to stable-14.1 failed. Please do this backport manually.

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 25, 2022

@AndyScherzinger Can you backport to version 14.1 and 14.2?

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 25, 2022

Likely failed due to the string related to a v15 feature, so not present before thus no backports needed and failing 😉

@Valdnet
Copy link
Contributor Author

Valdnet commented Aug 25, 2022

Thanks for the clarification 😉.

@AndyScherzinger AndyScherzinger added this to the 15.0.0 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakekniven rakekniven rakekniven approved these changes

@mahibi mahibi Awaiting requested review from mahibi

Assignees

@Valdnet Valdnet

Labels

backport-request

Projects

None yet

Milestone

15.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Valdnet @AndyScherzinger @rakekniven